LyraCore test audit work list

All eight findings are resolved. PR #641 merged as ee4d292a on 2026-10-10 after all nine checks passed. PR #640 had already merged the overlapping source-check removals. PR #641 removes 22 weak tests and adds five, for 17 fewer tests against its main baseline. CI gains 359 existing tests that it previously omitted.

Pull request #641

8 done, 0 in progress, 0 pending

Eight findings from the audit of commit 6f0d8c64. This document tracks the authorized fixes and removals. This work changes tests and tooling. It does not update realms.

#	Work	Status	Evidence
1	Setup-only tests Remove four construction tests that do not exercise the behavior they claim to cover. Source files at audit baseline module/src/import_meta.rs module/src/loot/mod.rs module/src/loot/tag.rs module/src/creatures/ai.rs	Done	Four setup-only tests removed. The rebased Module unit suite passed all 1,557 tests.
2	Copied test implementations Remove 15 tests and their private state models from GO model import, vmap lifecycle, and motion. Keep tests that call production calculations or an actual Store seam. Source files at audit baseline module/src/go_model.rs module/src/vmap.rs module/src/motion.rs	Done	Fifteen tests and their copied state models removed. Production calculations and real Store tests remain. The rebased Module suite passed.
3	Non-production text accepted as executable code Exclude comments, literals and test-only code from raw table-read checks. Preserve the documented Package API body helpers. Exercise subscription query values through the production function. Source files at audit baseline module/src/test_scan.rs gateway/src/stdb/connection.rs	Done	Nine shared scanner tests passed. They cover literal and comment decoys, generic functions, final fields and exact signatures containing array lengths. One new test checks production query lists. PR #640 already removed the other overlapping source-presence checks.
4	Importer fixtures share production offsets Use fixed source column positions in quest type and reward-mail fixtures so an incorrect production offset fails the test. Source files at audit baseline importer/src/main.rs	Done	All 399 enabled importer tests passed on the rebased branch. Earlier independent mutations of quest type, reward mail template and reward mail delay offsets failed as intended.
5	Useful tests missing from CI Run package-delta, module package API lint, and all Datascript suites in CI. Source files at audit baseline .github/workflows/rust.yml .github/workflows/runtime-scripts.yml crates/lyracore-package-delta/tests/common/mod.rs crates/lyracore-package-delta/tests/quest_identifiers.rs docs/testing.md .github/PULL_REQUEST_TEMPLATE.md	Done	CI now includes 289 package-delta tests, 44 package API checks and 26 more Bun tests (45 total). All passed locally. Fixed the stale quest fixture these new CI steps exposed. Testing docs and the PR checklist match the workflows.
6	Snapshots of implementation bodies Remove source-body equality tests that pin internal control flow and logging. Retain structural architecture checks and behavioral tests. Source files at audit baseline gateway/src/stdb/world_store.rs gateway/src/realm_core.rs module/src/auth.rs module/src/chat.rs module/src/mail_escrow.rs module/src/transfer/tests.rs module/src/vmap.rs module/src/creatures/cycle/harness.rs	Done	Completed by merged PR #640. Its removals include all 12 implementation-body snapshots identified by this audit. The rebase preserves those deletions and does not claim them as new removals in PR #641.
7	Duplicates and false idempotence claims Remove repeated mount projections, duplicated well-fed calculations, and the duplicate shared dungeon-map assertion. Source files at audit baseline module/src/mount.rs module/src/spell/tests.rs module/src/instance.rs	Done	Three duplicate tests removed. The remaining Module unit suite passed all 1,557 tests.
8	Determinism assertion accepts two failures Require both Datascript emissions to succeed and produce artifacts before comparing bytes. Make the refused-script fixture write synchronous. Source files at audit baseline datascripts/tests/emit.test.ts	Done	All four emission tests and all 45 Bun tests passed at f794e576. The earlier exit-1 mutation failed the determinism assertion. Artifact-content assertions read emitted output.

Verification

PR #641 merged at 2026-10-10 16:08 UTC as ee4d292a19269881c1ed0567a61dd75463cfa6ad. All nine hosted checks passed on the reviewed head f794e576, including all three durable shards and all 45 Bun tests. There were no unresolved review threads. The user explicitly authorized the override of the owner-only merge rule.
Runtime Scripts attempt 1 stalled in bun install for nearly 58 minutes with no output and was cancelled. Attempt 2 installed all 60 packages in 266 ms and passed all 45 tests in 17.66 seconds. The cancellation notification refers to the replaced attempt.
Rust suite at f794e576: 4,643 passed, 0 failed, 275 ignored. Durable and client-data tests were not run locally.
Bun at f794e576: 45 passed, 0 failed across four suites. Full Datascript typechecking passed.
Workspace Clippy with all targets, all features and warnings denied passed. Formatting, diff whitespace and the Module print-macro check passed.
Independent adversarial Standards and Spec reviews found no remaining actionable issues at f794e576. The integration fixes preserve exact signatures containing numeric literals, exclude quoted signature decoys and keep the documented Package API body-helper behavior.
The strict source scanner masks comments, literals and outer test-only code for raw table-read checks. Its nine tests include generic signatures, where clauses, final fields and match arms, and production code after test-only blocks. Package API code_of still preserves literals and test-only bodies; shape_of still collapses whitespace.
Earlier targeted mutations rejected three wrong importer offsets and a failing emitter. Two earlier commented-call mutations also failed, but PR #640 has since removed those source-presence assertions.
CI logs from the earlier PR head confirmed 289 Package Delta, 44 Package API and 26 additional Bun tests, for 359 newly enabled tests. The rebased local suite also passes these suites.
At 001bbe6b, durable shard 1 failed during the first private Standalone publish with connection refused. Logs stopped before the listening message and before gameplay assertions. The fixture, test and durable workflow are unchanged by this PR. All three durable shards passed on the rebased head.
PR #640 already removed the implementation-body snapshots and many source-presence checks. This rebase preserves those deletions and its new durable tests. PR #641 adds no durable replacement coverage for its four setup-only tests, 15 copied-model tests or three duplicate tests.
Changes affect tests, test support, CI, test documentation and stale comments. No gameplay logic, schema or realm changes.